Skip to content

update ja docs #1733

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 14, 2017
Merged

update ja docs #1733

merged 6 commits into from
Sep 14, 2017

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Sep 13, 2017

No description provided.

@kazupon kazupon requested a review from ktsn September 13, 2017 02:19
ktsn
ktsn reviewed Sep 14, 2017
View reviewed changes
docs/ja/essentials/navigation.md Outdated
@@ -31,18 +31,18 @@ router.push({ name: 'user', params: { userId: 123 }})
router.push({ path: 'register', query: { plan: 'private' }})
```

**Note**: `params` are ignored if a `path` is provided, which is not the case for `query`, as shown in the example above.
Instead, you need to provide the `name` of the route or manually specify the whole `path` with any parameter:
**注意**: `params` は、上記例に示すように、`path` が提供されている場合、これは `query` に対するケースとは異なり、無視されます。
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

query の話が主題に混じっていて少しわかりづらく感じるので以下のように文を区切ってはどうでしょうか？

params は、上記例に示すように、path が提供されている場合は無視されます。これは query に対するケースとは異なります。

docs/ja/essentials/navigation.md Outdated
**Note**: `params` are ignored if a `path` is provided, which is not the case for `query`, as shown in the example above.
Instead, you need to provide the `name` of the route or manually specify the whole `path` with any parameter:
**注意**: `params` は、上記例に示すように、`path` が提供されている場合、これは `query` に対するケースとは異なり、無視されます。
代わりに、ルートの `name` か任意のパラメータで `path` 全体を手動で指定する必要があります:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

「任意のパラメータを付与した path 全体」とすると、パラメータとpathの関係がよりわかりやすくなるかなと思いました。

@kazupon
Copy link
Member Author

kazupon commented Sep 14, 2017

ありがとうございます！修正しました！

@kazupon kazupon merged commit 3827f16 into vuejs:dev Sep 14, 2017
@kazupon kazupon deleted the docs/ja branch September 14, 2017 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktsn ktsn ktsn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kazupon @ktsn